Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win32/php_stdint.h is removed as of PHP 8.0.0 #84

Closed
wants to merge 1 commit into from

Conversation

cmb69
Copy link

@cmb69 cmb69 commented Jan 12, 2021

@nono303
Copy link

nono303 commented Jan 13, 2021

hi @cmb69
Have a look on #80 (comment) as NON_BLOCKING_IO_php8 might be used for PHP >=7.2

@cmb69
Copy link
Author

cmb69 commented Jan 13, 2021

NON_BLOCKING_IO_php8 might be used for PHP >=7.2

Ah, I wasn't aware of that. However, that shouldn't be an issue, since stdint.h is available in the platform toolset for quite some time. I just did a build with PHP 7.2.34 without any issues; I can't run the testsuite, though, since I don't have memcached installed.

If you like, I can provide a PR with AppVeyor CI integration (building and packaging on 7.2 - 8.0), so at least this could be checked. And maybe someone with a memcached setup could verify these builds then.

@Jan-E
Copy link
Contributor

Jan-E commented Oct 26, 2022

A patch like this would make sure that for PHP 7.0/7.1 (VC14) and PHP 7.2-7.4 (VC15) the existing win32/php_stdint.h is used and for PHP 8.0+ stdint.h:

-#include <win32/php_stdint.h>
+#if defined(_MSC_VER) && _MSC_VER < 1920
+# include "win32/php_stdint.h"
+#else
+# include <stdint.h>
+#endif

But whatever solution is chosen: the current repo still does not build on Windows for PHP 8+.

cmb69 added a commit to cmb69/php-ftw that referenced this pull request Jan 11, 2023
Not sure if that works, since memcache 8.0 cannot be built for PHP 8 on
Windows[1].

[1] <websupport-sk/pecl-memcache#84>
@Jan-E
Copy link
Contributor

Jan-E commented Apr 30, 2023

The release for PHP 8.2 will not build on Windows because you did not solve the win32/php_stdint.h issue.

@cmb69
Copy link
Author

cmb69 commented Oct 30, 2024

The issue has been resolved via 7e7fb52, so I'm closing this PR.

@cmb69 cmb69 closed this Oct 30, 2024
@cmb69 cmb69 deleted the cmb/stdint branch October 30, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants